Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacement in document body #1451

Merged
merged 2 commits into from Mar 1, 2024
Merged

feat: replacement in document body #1451

merged 2 commits into from Mar 1, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 1, 2024

  • I am sure that the code is update-to-date with the dev branch.

close https://github.com/dream-num/univer-pro/issues/286

Copy link

github-actions bot commented Mar 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.63%. Comparing base (4d49dad) to head (a5a8d09).

Files Patch % Lines
packages/core/src/docs/data-model/replacement.ts 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1451      +/-   ##
==========================================
+ Coverage   31.26%   31.63%   +0.37%     
==========================================
  Files         876      877       +1     
  Lines       49146    49168      +22     
  Branches    10142    10149       +7     
==========================================
+ Hits        15364    15556     +192     
+ Misses      33782    33612     -170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review March 1, 2024 07:21
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@wzhudev wzhudev merged commit e258abd into dev Mar 1, 2024
7 checks passed
@wzhudev wzhudev deleted the feat/rich-text-replacement branch March 1, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants