Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): copy error when range is empty #1488

Merged
merged 1 commit into from Mar 5, 2024
Merged

fix(doc): copy error when range is empty #1488

merged 1 commit into from Mar 5, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1485

@Jocs Jocs marked this pull request as ready for review March 5, 2024 10:57
@Jocs Jocs requested a review from jikkai as a code owner March 5, 2024 10:57
@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 32.58%. Comparing base (885ba4b) to head (7185144).

Files Patch % Lines
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1488      +/-   ##
==========================================
- Coverage   32.59%   32.58%   -0.01%     
==========================================
  Files         905      905              
  Lines       50121    50123       +2     
  Branches    10431    10432       +1     
==========================================
  Hits        16335    16335              
- Misses      33786    33788       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@Jocs Jocs merged commit 1ae73ca into dev Mar 5, 2024
7 checks passed
@Jocs Jocs deleted the fix/copy branch March 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 文档不选中任何内容时直接使用快捷ctrl+c复制控制台报错
3 participants