Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): cursor and menu and single choice #1499

Merged
merged 3 commits into from Mar 7, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 6, 2024

  • cursor position fix
  • menu destroy fix
  • single range choice
  • reduce frequence for value change

close #

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 32.66%. Comparing base (271574a) to head (a7ee2ae).
Report is 3 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/editor/editor.service.ts 0.00% 17 Missing ⚠️
packages/ui/src/components/editor/TextEditor.tsx 0.00% 14 Missing ⚠️
...src/services/selection/selection-render.service.ts 37.50% 5 Missing ⚠️
...ui/src/controllers/doc-editor-bridge.controller.ts 0.00% 4 Missing ⚠️
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 3 Missing ⚠️
packages/core/src/shared/compare.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1499      +/-   ##
==========================================
- Coverage   32.67%   32.66%   -0.02%     
==========================================
  Files         906      909       +3     
  Lines       50465    50560      +95     
  Branches    10520    10533      +13     
==========================================
+ Hits        16491    16515      +24     
- Misses      33974    34045      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wzhudev wzhudev merged commit 6cdccde into dev Mar 7, 2024
7 checks passed
@wzhudev wzhudev deleted the fix-range-selector-1 branch March 7, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants