Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): range selector #1503

Merged
merged 4 commits into from Mar 7, 2024
Merged

fix(editor): range selector #1503

merged 4 commits into from Mar 7, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 7, 2024

  • range error
  • reduce value change
  • focus error

close #

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 32.78%. Comparing base (ed27e84) to head (de112fa).

❗ Current head de112fa differs from pull request most recent head 5052e1f. Consider uploading reports for the commit 5052e1f to get more accurate results

Files Patch % Lines
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 15 Missing ⚠️
...ets-ui/src/controllers/editor-bridge.controller.ts 0.00% 12 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 9 Missing ⚠️
.../services/range-selector/range-selector.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1503      +/-   ##
==========================================
- Coverage   32.79%   32.78%   -0.02%     
==========================================
  Files         911      911              
  Lines       50630    50652      +22     
  Branches    10557    10562       +5     
==========================================
  Hits        16605    16605              
- Misses      34025    34047      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit eee2aab into dev Mar 7, 2024
7 checks passed
@DR-Univer DR-Univer deleted the fix-range-selector-4 branch March 7, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant