Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline format in cell with rich text #1560

Merged
merged 1 commit into from Mar 15, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 12, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1548

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 12, 2024
@Jocs Jocs marked this pull request as ready for review March 12, 2024 12:20
Copy link

github-actions bot commented Mar 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 32.85%. Comparing base (5aeb65f) to head (8489d74).
Report is 14 commits behind head on dev.

Files Patch % Lines
...rc/commands/mutations/set-range-values.mutation.ts 11.76% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1560      +/-   ##
==========================================
- Coverage   32.86%   32.85%   -0.01%     
==========================================
  Files         919      919              
  Lines       51202    51206       +4     
  Branches    10661    10662       +1     
==========================================
  Hits        16825    16825              
- Misses      34377    34381       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 14, 2024
@univer-bot univer-bot bot removed qa:untested This PR is ready to be tested qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Mar 14, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 14, 2024
@Jocs Jocs merged commit 447a095 into dev Mar 15, 2024
7 checks passed
@Jocs Jocs deleted the fix/inline-format-in-cell-2 branch March 15, 2024 03:34
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 在sheet里通过单元格对其富文本设置样式,富文本样式会丢失
3 participants