Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): some bugs about copy&paste / remove row&col / autofill #1561

Merged
merged 7 commits into from Apr 3, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Mar 12, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1541
close #1397
close #1253

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7
Copy link

#1253 @yuhongz
删除列后白屏,路径:选中A6单元格删除行后undo,再次选中A6单元格后删除列
2024_3_14 16_45_11 video.webm

@univer-bot univer-bot bot removed qa:untested This PR is ready to be tested qa:rejected labels Mar 14, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


#1253 @yuhongz
White screen after deleting the column, path: select cell A6 and delete the row and then undo, select cell A6 again and delete the column.
2024_3_14 16_45_11 video.webm

@yuhongz yuhongz added the qa:untested This PR is ready to be tested label Mar 25, 2024
@univer-bot univer-bot bot removed the qa:rejected label Mar 25, 2024
@jikkai jikkai changed the title fix(sheet): some bugs about copy&paste / remove row&col / autofill fix(sheets): some bugs about copy&paste / remove row&col / autofill Mar 28, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 1, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 29.79%. Comparing base (785e141) to head (1f4fe4b).

Files Patch % Lines
.../sheets-ui/src/controllers/auto-fill.controller.ts 41.37% 17 Missing ⚠️
...ets-ui/src/services/clipboard/html-to-usm/utils.ts 0.00% 4 Missing ⚠️
...services/clipboard/html-to-usm/parse-node-style.ts 0.00% 2 Missing ⚠️
...ui/src/services/clipboard/html-to-usm/converter.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1561   +/-   ##
=======================================
  Coverage   29.79%   29.79%           
=======================================
  Files        1143     1143           
  Lines       62050    62064   +14     
  Branches    13021    13023    +2     
=======================================
+ Hits        18486    18491    +5     
- Misses      43564    43573    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Apr 2, 2024

Unit tests required.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit e1072c7 into dev Apr 3, 2024
8 checks passed
@wzhudev wzhudev deleted the yuhongz/bugfixs-14 branch April 3, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
4 participants