Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(find-replace): fix dialog issues #1590

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 15, 2024

  • I am sure that the code is update-to-date with the dev branch.

close https://github.com/dream-num/univer-pro/issues/413
close https://github.com/dream-num/univer-pro/issues/365

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 15, 2024
Copy link

github-actions bot commented Mar 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 32.37%. Comparing base (75b4395) to head (45338b4).
Report is 15 commits behind head on dev.

Files Patch % Lines
...replace/src/controllers/find-replace.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1590   +/-   ##
=======================================
  Coverage   32.37%   32.37%           
=======================================
  Files         923      923           
  Lines       52098    52098           
  Branches    10872    10872           
=======================================
  Hits        16867    16867           
  Misses      35231    35231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 16, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 16, 2024
@jikkai jikkai merged commit 2390086 into dev Mar 18, 2024
8 checks passed
@jikkai jikkai deleted the wzhudev/fix-dialog-position branch March 18, 2024 14:11
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants