Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): ssr support #1603

Merged
merged 1 commit into from Mar 15, 2024
Merged

feat(design): ssr support #1603

merged 1 commit into from Mar 15, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 15, 2024

  • I am sure that the code is update-to-date with the dev branch.

Copy link

github-actions bot commented Mar 15, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.42%. Comparing base (ab76ebd) to head (8741d85).

Files Patch % Lines
packages/design/src/components/dialog/Dialog.tsx 0.00% 1 Missing ⚠️
packages/design/src/components/menu/Menu.tsx 0.00% 1 Missing ⚠️
packages/design/src/components/select/Select.tsx 0.00% 1 Missing ⚠️
packages/design/src/themes/theme.ts 0.00% 1 Missing ⚠️
...es/ui/src/components/notification/Notification.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1603   +/-   ##
=======================================
  Coverage   32.42%   32.42%           
=======================================
  Files         923      923           
  Lines       52167    52174    +7     
  Branches    10884    10896   +12     
=======================================
+ Hits        16917    16920    +3     
- Misses      35250    35254    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit cdb7d49 into dev Mar 15, 2024
7 checks passed
@jikkai jikkai deleted the feat/design-ssr branch March 15, 2024 17:51
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant