Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui)!: prevent formula bar from displaying when header is set to false & remove unused code #1633

Merged
merged 1 commit into from Mar 19, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Mar 19, 2024

close #1631

Breaking Changes

Merged toolbar into header configuration. toolbar option removed, use header to control both header and toolbar visibility.

Before:

univer.registerPlugin(UniverUIPlugin, {
    container: 'app',
    header: true,
    toolbar: true,
    footer: true,
});

After:

univer.registerPlugin(UniverUIPlugin, {
    container: 'app',
    header: true,
-    toolbar: true
    footer: true,
});

Copy link

github-actions bot commented Mar 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.81%. Comparing base (2390086) to head (486a3a0).

Files Patch % Lines
packages/ui/src/views/App.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1633   +/-   ##
=======================================
  Coverage   32.81%   32.81%           
=======================================
  Files         928      927    -1     
  Lines       52281    52280    -1     
  Branches    10918    10920    +2     
=======================================
  Hits        17156    17156           
+ Misses      35125    35124    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit e3d875c into dev Mar 19, 2024
7 checks passed
@jikkai jikkai deleted the feat/ui-header branch March 19, 2024 03:39
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Formula box visible when hiding the header.
1 participant