fix(facade): should not return promise in syncExecuteCommand #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1648 +/- ##
=======================================
Coverage 32.89% 32.89%
=======================================
Files 933 933
Lines 52495 52495
Branches 11004 11004
=======================================
Hits 17267 17267
Misses 35228 35228 ☔ View full report in Codecov by Sentry. |
hexf00
added
qa:untested
Jocs
approved these changes
Mar 20, 2024
hexf00
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx, #yyy, #zzzz
Command handler should not return a promise.use draw logo to test
https://github.com/dream-num/univer/blob/dev/examples/src/sheets-uniscript/draw-univer-logo.js