Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): preload the editor #1662

Merged
merged 4 commits into from Mar 23, 2024
Merged

fix(editor): preload the editor #1662

merged 4 commits into from Mar 23, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #1441

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 32.74%. Comparing base (a875a31) to head (72d75bd).

Files Patch % Lines
...en-editor/src/controllers/zen-editor.controller.ts 0.00% 4 Missing ⚠️
.../services/editor/formula-editor-manager.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1662      +/-   ##
==========================================
- Coverage   32.75%   32.74%   -0.01%     
==========================================
  Files         951      951              
  Lines       53329    53332       +3     
  Branches    11129    11130       +1     
==========================================
  Hits        17466    17466              
- Misses      35863    35866       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 23, 2024
@DR-Univer DR-Univer merged commit 09ceb16 into dev Mar 23, 2024
8 checks passed
@jikkai jikkai deleted the fix-editor-steady branch May 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]刷新表格后直接编辑单元格,无法编辑
3 participants