fix(ui): cleanup DOMs when dispose

[hexf00]

When the univer is destroyed and then re created, there are residual doms that have not been cleaned up

A description of the proposed changes.

remove iframe and .univer-theme when univer dispose called

How to test them.

Replace the file \examples\src\sheets\main.ts with the following content and run setupUniver() multiple times in the console

import { LocaleType, LogLevel, Univer } from '@univerjs/core';
import { defaultTheme } from '@univerjs/design';
import { UniverDocsPlugin } from '@univerjs/docs';
import { UniverDocsUIPlugin } from '@univerjs/docs-ui';
import { UniverFormulaEnginePlugin } from '@univerjs/engine-formula';
import { UniverRenderEnginePlugin } from '@univerjs/engine-render';
import { UniverFindReplacePlugin } from '@univerjs/find-replace';
import type { IUniverRPCMainThreadConfig } from '@univerjs/rpc';
import { UniverRPCMainThreadPlugin } from '@univerjs/rpc';
import { UniverSheetsPlugin } from '@univerjs/sheets';
import { UniverSheetsFindReplacePlugin } from '@univerjs/sheets-find-replace';
import { UniverSheetsFormulaPlugin } from '@univerjs/sheets-formula';
import { UniverSheetsNumfmtPlugin } from '@univerjs/sheets-numfmt';
import { UniverSheetsUIPlugin } from '@univerjs/sheets-ui';
import { UniverSheetsZenEditorPlugin } from '@univerjs/sheets-zen-editor';
import { UniverUIPlugin } from '@univerjs/ui';

import { DEFAULT_WORKBOOK_DATA_DEMO } from '../data';
import { DebuggerPlugin } from '../plugins/debugger';
import { locales } from './locales';

const LOAD_LAZY_PLUGINS_TIMEOUT = 1_000;

declare global {
    interface Window {
        univer?: Univer;
        setupUniver?: () => void;
    }
}

const setupUniver = async () => {
    if (window.univer) {
        window.univer.dispose();
    }

    // univer
    const univer = new Univer({
        theme: defaultTheme,
        locale: LocaleType.ZH_CN,
        locales,
        logLevel: LogLevel.VERBOSE,
    });

// core plugins
    univer.registerPlugin(UniverDocsPlugin, {
        hasScroll: false,
    });
    univer.registerPlugin(UniverRenderEnginePlugin);
    univer.registerPlugin(UniverUIPlugin, {
        container: 'app',
        header: true,
        footer: true,
    });

    univer.registerPlugin(UniverDocsUIPlugin);

    univer.registerPlugin(UniverSheetsPlugin, {
        notExecuteFormula: true,
    });
    univer.registerPlugin(UniverSheetsUIPlugin);

// sheet feature plugins

    univer.registerPlugin(UniverSheetsNumfmtPlugin);
    univer.registerPlugin(DebuggerPlugin);
    univer.registerPlugin(UniverSheetsZenEditorPlugin);
    univer.registerPlugin(UniverFormulaEnginePlugin, {
        notExecuteFormula: true,
    });
    univer.registerPlugin(UniverSheetsFormulaPlugin);
    univer.registerPlugin(UniverRPCMainThreadPlugin, {
        workerURL: './worker.js',
    } as IUniverRPCMainThreadConfig);

// find replace
    univer.registerPlugin(UniverFindReplacePlugin);
    univer.registerPlugin(UniverSheetsFindReplacePlugin);

// create univer sheet instance
    univer.createUniverSheet(DEFAULT_WORKBOOK_DATA_DEMO);
    setTimeout(() => {
        import('./lazy').then((lazy) => {
            const plugins = lazy.default();
            plugins.forEach((p) => univer.registerPlugin(p[0], p[1]));
        });
    }, LOAD_LAZY_PLUGINS_TIMEOUT);

    window.univer = univer;
};
window.setupUniver = setupUniver;

setupUniver();

[github-actions]

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.95%. Comparing base (ff686e6) to head (272c564).

Files	Patch %	Lines
packages/ui/src/views/App.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1663   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files         946      946           
  Lines       52819    52823    +4     
  Branches    11050    11050           
=======================================
+ Hits        17405    17408    +3     
- Misses      35414    35415    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wzhudev]

Some code can be simplified.