Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): list indent and hanging #1675

Merged
merged 3 commits into from Apr 7, 2024
Merged

fix(docs): list indent and hanging #1675

merged 3 commits into from Apr 7, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 23, 2024

  • Support indent first line and hang.
  • Optimization of create list, and remove modify data model in render layer.

@zhaolixin7 need to test the function of list.

close #1582

Copy link

github-actions bot commented Mar 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 29.68%. Comparing base (3acf286) to head (7941d30).

Files Patch % Lines
...ackages/docs/src/commands/commands/list.command.ts 0.00% 9 Missing ⚠️
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 5 Missing ⚠️
...kages/docs/src/commands/commands/delete.command.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1675   +/-   ##
=======================================
  Coverage   29.68%   29.68%           
=======================================
  Files        1158     1158           
  Lines       62780    62772    -8     
  Branches    13177    13176    -1     
=======================================
  Hits        18634    18634           
+ Misses      44146    44138    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review March 23, 2024 09:48
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 23, 2024
@jikkai jikkai changed the title fix(doc): list indent and hanging fix(docs): list indent and hanging Mar 28, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 2, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 2, 2024
@Jocs Jocs merged commit 4020055 into dev Apr 7, 2024
8 checks passed
@Jocs Jocs deleted the refactor/indent-hang branch April 7, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Ticket] Refactor paragraph layout
3 participants