Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): range selector and range drag #1713

Merged
merged 2 commits into from Mar 27, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

  1. range selector select range error
  2. drag to update range error

Copy link

github-actions bot commented Mar 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 32.33%. Comparing base (9ab34b6) to head (f2bead9).

Files Patch % Lines
...ets/src/commands/commands/utils/selection-utils.ts 21.42% 11 Missing ⚠️
packages/ui/src/services/editor/editor.service.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1713      +/-   ##
==========================================
- Coverage   32.33%   32.33%   -0.01%     
==========================================
  Files         976      976              
  Lines       54152    54168      +16     
  Branches    11284    11291       +7     
==========================================
+ Hits        17511    17513       +2     
- Misses      36641    36655      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 02e9647 into dev Mar 27, 2024
8 checks passed
@DR-Univer DR-Univer deleted the fix-editor-selector-and-drag branch March 27, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant