Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conditional-formatting): support set cfId #1753

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 1, 2024

No description provided.

@Gggpound Gggpound force-pushed the gggpound/feat-support-set-cfId-0401 branch from e4b66b9 to 7bb8c28 Compare April 1, 2024 09:35
Copy link

github-actions bot commented Apr 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 46.57534% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 29.86%. Comparing base (4b35198) to head (c8c0f03).

Files Patch % Lines
...ands/mutations/delete-conditional-rule.mutation.ts 0.00% 16 Missing ⚠️
.../sheets-conditional-formatting/src/utils/anchor.ts 79.74% 16 Missing ⚠️
...atting-ui/src/components/panel/rule-list/index.tsx 0.00% 15 Missing ⚠️
...ng/src/models/conditional-formatting-rule-model.ts 16.66% 15 Missing ⚠️
...atting-ui/src/commands/commands/move-cf.command.ts 0.00% 7 Missing ⚠️
...mmands/mutations/move-conditional-rule.mutation.ts 14.28% 6 Missing ⚠️
...ommands/mutations/set-conditional-rule.mutation.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1753      +/-   ##
==========================================
+ Coverage   29.80%   29.86%   +0.05%     
==========================================
  Files        1143     1145       +2     
  Lines       62068    62156      +88     
  Branches    13025    13061      +36     
==========================================
+ Hits        18502    18565      +63     
- Misses      43566    43591      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the gggpound/feat-support-set-cfId-0401 branch from 7bb8c28 to cfe2083 Compare April 1, 2024 11:37
@Gggpound Gggpound force-pushed the gggpound/feat-support-set-cfId-0401 branch from cfe2083 to 3826e7b Compare April 1, 2024 11:43
@dream-num dream-num deleted a comment from univer-bot bot Apr 2, 2024
@dream-num dream-num deleted a comment from univer-bot bot Apr 2, 2024
@Gggpound Gggpound force-pushed the gggpound/feat-support-set-cfId-0401 branch from cfea213 to ebd166b Compare April 2, 2024 16:19
@Gggpound Gggpound force-pushed the gggpound/feat-support-set-cfId-0401 branch from e847591 to c8c0f03 Compare April 3, 2024 11:31
@Gggpound Gggpound merged commit 4a277f9 into dev Apr 3, 2024
8 checks passed
@Gggpound Gggpound deleted the gggpound/feat-support-set-cfId-0401 branch April 3, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants