New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): fix some copy/paste bugs #1754
Conversation
Origin Title: fix(sheet): fix some copy/paste bugs Title: fix(sheet): fix some copy/paste bugs repair
& |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1754 +/- ##
==========================================
+ Coverage 29.54% 29.71% +0.16%
==========================================
Files 1168 1169 +1
Lines 63548 63824 +276
Branches 13425 13531 +106
==========================================
+ Hits 18773 18963 +190
- Misses 44775 44861 +86 ☔ View full report in Codecov by Sentry. |
View Deployment
|
Please build unit tests so we can make sure that these problems wouldn't occur in the future. |
df3ee81
to
baec8c7
Compare
return newStyleString.trim(); | ||
} | ||
|
||
function parseTableByHtml(htmlElement: HTMLIFrameElement, skeleton?: SpreadsheetSkeleton) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is too long, and it requires additional comments to improve its understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2a50fa8
to
cc34779
Compare
@ybzky #1619 粘贴列不够时未扩展 |
@ybzky #1619 Paste column not expanded when not enough |
Please rebase this PR. |
4311c44
to
480257a
Compare
修复
&
close #1619 #1624 #1585 #1559 #1209 #1082 #1389