Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add Textarea component #1778

Merged
merged 1 commit into from Apr 2, 2024
Merged

feat(design): add Textarea component #1778

merged 1 commit into from Apr 2, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 2, 2024

@jikkai jikkai requested review from wzhudev and Jocs as code owners April 2, 2024 12:00
Copy link

github-actions bot commented Apr 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 29.69%. Comparing base (17d4923) to head (a4878b7).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ckages/design/src/components/textarea/Textarea.tsx 0.00% 10 Missing ⚠️
...esign/src/components/textarea/Textarea.stories.tsx 0.00% 7 Missing ⚠️
...ui/src/components/range-selector/RangeSelector.tsx 0.00% 4 Missing ⚠️
...ages/design/src/components/input/InputWithSlot.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1778      +/-   ##
==========================================
- Coverage   29.70%   29.69%   -0.01%     
==========================================
  Files        1141     1143       +2     
  Lines       61925    61940      +15     
  Branches    12962    12963       +1     
==========================================
  Hits        18392    18392              
- Misses      43533    43548      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit a2dd33d into dev Apr 2, 2024
9 checks passed
@jikkai jikkai deleted the feat/textarea branch April 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants