Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): strikethrough position is incorrect #1836

Merged
merged 3 commits into from Apr 11, 2024
Merged

fix(docs): strikethrough position is incorrect #1836

merged 3 commits into from Apr 11, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 9, 2024

close #1757

@Jocs Jocs marked this pull request as ready for review April 9, 2024 07:12
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 29.57%. Comparing base (9e76a28) to head (19e8a72).
Report is 2 commits behind head on dev.

Files Patch % Lines
...gine-render/src/components/docs/extensions/line.ts 0.00% 7 Missing ⚠️
...c/components/docs/extensions/font-and-base-line.ts 0.00% 4 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1836      +/-   ##
==========================================
- Coverage   29.96%   29.57%   -0.39%     
==========================================
  Files        1163     1163              
  Lines       63128    63135       +7     
  Branches    13273    13277       +4     
==========================================
- Hits        18914    18675     -239     
- Misses      44214    44460     +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

@Jocs 删除线的位置还是不对
image

@univer-bot
Copy link

univer-bot bot commented Apr 10, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Jocs The strikethrough position is still wrong.
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 10, 2024
@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Apr 10, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 11, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 11, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 3f68158 into dev Apr 11, 2024
8 checks passed
@wzhudev wzhudev deleted the fix/linetrough branch April 11, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The strikethrough position is incorrect when the document content is set to superscript.
3 participants