Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): the line leader punctuation is not squeezed #1867

Merged
merged 1 commit into from Apr 16, 2024
Merged

fix(docs): the line leader punctuation is not squeezed #1867

merged 1 commit into from Apr 16, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 11, 2024

close #1849

@Jocs Jocs changed the title fix: punctuation adjustment fix(docs): punctuation adjustment Apr 11, 2024
@Jocs Jocs marked this pull request as ready for review April 11, 2024 09:04
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.57%. Comparing base (08e8d58) to head (37b5f9b).
Report is 11 commits behind head on dev.

Files Patch % Lines
...nts/docs/layout/block/paragraph/line-adjustment.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1867      +/-   ##
==========================================
- Coverage   29.57%   29.57%   -0.01%     
==========================================
  Files        1163     1163              
  Lines       63135    63136       +1     
  Branches    13277    13277              
==========================================
  Hits        18675    18675              
- Misses      44460    44461       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 13, 2024
@wzhudev
Copy link
Member

wzhudev commented Apr 13, 2024

Could the title be more specific about the issue it is going to fix? @Jocs

@Jocs Jocs changed the title fix(docs): punctuation adjustment fix(docs): the line leader punctuation is not squeezed Apr 13, 2024
@Jocs
Copy link
Contributor Author

Jocs commented Apr 13, 2024

Could the title be more specific about the issue it is going to fix? @Jocs

cool, done.

@Jocs Jocs requested a review from Gggpound April 16, 2024 10:49
@Jocs Jocs merged commit e921128 into dev Apr 16, 2024
10 checks passed
@Jocs Jocs deleted the fix/punctuation-adjustment-at-begining branch April 16, 2024 11:10
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
@Jocs @Gggpound
fix: punctuation adjustment (#1867)
5ba2dbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@wzhudev wzhudev Awaiting requested review from wzhudev

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
4 participants
@Jocs @wzhudev @Gggpound @zhaolixin7