feat(engine-formula): add iseven isodd #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1873 +/- ##
==========================================
+ Coverage 29.55% 29.58% +0.02%
==========================================
Files 1163 1165 +2
Lines 63215 63239 +24
Branches 13304 13312 +8
==========================================
+ Hits 18685 18707 +22
- Misses 44530 44532 +2 ☔ View full report in Codecov by Sentry. |
DR-Univer
reviewed
Apr 12, 2024
packages/engine-formula/src/functions/information/iseven/__tests__/iseven.spec.ts
Outdated
Show resolved
Hide resolved
Dushusir
reviewed
Apr 12, 2024
packages/engine-formula/src/functions/information/iseven/iseven.ts
Outdated
Show resolved
Hide resolved
Dushusir
reviewed
Apr 12, 2024
DR-Univer
approved these changes
Apr 12, 2024
Dushusir
approved these changes
Apr 12, 2024
Jocs
pushed a commit
that referenced
this pull request
Apr 13, 2024
* feat(engine-formula): add iseven isodd * feat: register isodd * chore: fix typo * feat: deal with i18n * test: add tests for not convertable situations * feat: deal with boolean values * fix: test * fix: fix array value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO