Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): disregarding computation beyond the tabl… #1891

Merged
merged 1 commit into from Apr 13, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 13, 2024

Here's the corrected and improved version of your text:

"Establishing an extra-large conditional formatting region, then assessing whether the conditional formatting renders correctly.

The rationale for this modification is:

Assuming a subtable occupies a 10x10 region, but a 100x100 conditional formatting region has been configured. During computation, the conditional formatting should exclude the area exceeding the 10x10 region.

When setting an exceedingly large range on the panel, there is no need for an error message."

@Gggpound Gggpound added the qa:untested This PR is ready to be tested label Apr 13, 2024
Copy link

github-actions bot commented Apr 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound force-pushed the gggpound/fix-conditional-formatting-0413 branch from 288e8ed to e556871 Compare April 13, 2024 09:07
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 29.55%. Comparing base (e7f1036) to head (e556871).
Report is 9 commits behind head on dev.

Files Patch % Lines
...ting/src/services/calculate-unit/highlight-cell.ts 34.78% 30 Missing ⚠️
...al-formatting/src/services/calculate-unit/utils.ts 70.96% 9 Missing ⚠️
...formatting/src/services/calculate-unit/icon-set.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1891      +/-   ##
==========================================
+ Coverage   29.49%   29.55%   +0.06%     
==========================================
  Files        1168     1168              
  Lines       63532    63561      +29     
  Branches    13382    13426      +44     
==========================================
+ Hits        18736    18784      +48     
+ Misses      44796    44777      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 13, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 13, 2024
@Gggpound Gggpound merged commit c14a3a8 into dev Apr 13, 2024
9 checks passed
@Gggpound Gggpound deleted the gggpound/fix-conditional-formatting-0413 branch April 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants