Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine-render): add render unit system #2025

Merged
merged 3 commits into from Apr 23, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 21, 2024

No description provided.

Copy link

github-actions bot commented Apr 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 6.17284% with 152 lines in your changes are missing coverage. Please review.

Project coverage is 29.58%. Comparing base (8c3bb90) to head (89740c1).

Files Patch % Lines
...src/controllers/header-unhide.render-controller.ts 0.00% 32 Missing ⚠️
...ender/src/render-manager/render-manager.service.ts 0.00% 31 Missing ⚠️
...es/engine-render/src/render-manager/render-unit.ts 0.00% 23 Missing ⚠️
...ets-ui/src/controllers/freeze.render-controller.ts 0.00% 18 Missing ⚠️
...src/controllers/header-resize.render-controller.ts 0.00% 17 Missing ⚠️
...sheets-ui/src/controllers/utils/component-tools.ts 36.84% 12 Missing ⚠️
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 6 Missing ⚠️
packages/sheets-ui/src/sheets-ui-plugin.ts 0.00% 5 Missing ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 42.85% 4 Missing ⚠️
packages/core/src/shared/lifecycle.ts 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2025      +/-   ##
==========================================
- Coverage   29.60%   29.58%   -0.02%     
==========================================
  Files        1179     1180       +1     
  Lines       64277    64327      +50     
  Branches    13617    13617              
==========================================
+ Hits        19028    19032       +4     
- Misses      45249    45295      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the wzhudev/render-unit branch 2 times, most recently from 6a183e5 to 3572ae0 Compare April 21, 2024 05:54
refactor: simplify skeleton usage in render controllers

chore: remove useless file

fix: fix get canvas size on header resize
@wzhudev wzhudev merged commit a5243da into dev Apr 23, 2024
8 checks passed
@wzhudev wzhudev deleted the wzhudev/render-unit branch April 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants