fix: fix current render handling in desktop controller #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jocs
reviewed
Apr 24, 2024
| @@ -76,6 +76,8 @@ export class DesktopUIController extends Disposable implements IDesktopUIControl | |||
| this._renderManagerService.currentRender$.subscribe((renderId) => { | |||
| if (renderId) { | |||
| const render = this._renderManagerService.getRenderById(renderId)!; | |||
| if (!render.unitId) return; | |||
There was a problem hiding this comment.
Under what circumstances does unitId not exist?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2067 +/- ##
==========================================
- Coverage 29.71% 29.71% -0.01%
==========================================
Files 1178 1178
Lines 63982 63983 +1
Branches 13589 13590 +1
==========================================
Hits 19011 19011
- Misses 44971 44972 +1 ☔ View full report in Codecov by Sentry. |
View Deployment
|
jikkai
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.