fix: global-zone componentKey initial value error #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2100 +/- ##
==========================================
- Coverage 31.06% 31.06% -0.01%
==========================================
Files 1207 1207
Lines 66172 66176 +4
Branches 13994 13994
==========================================
Hits 20556 20556
- Misses 45616 45620 +4 ☔ View full report in Codecov by Sentry. |
Dushusir
approved these changes
Apr 28, 2024
View Deployment
|
wzhudev
reviewed
Apr 28, 2024
| @@ -25,15 +25,22 @@ import type { IGlobalZoneService } from './global-zone.service'; | |||
| export class DesktopGlobalZoneService implements IGlobalZoneService { | |||
| readonly visible$ = new Subject<boolean>(); | |||
| readonly componentKey$ = new Subject<string>(); | |||
There was a problem hiding this comment.
Making this a BehaviorSubject and giving it an initial value would be a simpler fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx, #yyy, #zzzz