Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): array formula update when ref-range changed #1134

Closed
wants to merge 8 commits into from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jan 13, 2024

Some details move to #1659

  • I am sure that the code is update-to-date with the dev branch.
  • fix formula bug
  • facade api change name

Copy link

github-actions bot commented Jan 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fa67e0) 29.59% compared to head (f7999f2) 29.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1134   +/-   ##
=======================================
  Coverage   29.59%   29.59%           
=======================================
  Files         841      841           
  Lines       47739    47739           
  Branches     9776     9776           
=======================================
  Hits        14127    14127           
  Misses      33612    33612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/formula-offset-bug branch 2 times, most recently from 244fab4 to 2110121 Compare January 16, 2024 07:55
@Dushusir Dushusir changed the title fix(formula): ref-range fix(formula): array formula update when ref-range changed Jan 16, 2024
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:untested This PR is ready to be tested labels Jan 16, 2024
@Dushusir Dushusir marked this pull request as ready for review January 17, 2024 03:21
@Dushusir Dushusir removed the qa:untested This PR is ready to be tested label Jan 17, 2024
@Dushusir Dushusir marked this pull request as draft January 18, 2024 10:38
@Dushusir
Copy link
Member Author

Dushusir commented Jan 18, 2024

After remove insert range, delete range, insert row/col
please @me cc @yuhongz

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


After remove insert range, delete range
please @me cc @yuhongz

@Dushusir Dushusir force-pushed the dushusir/formula-offset-bug branch 2 times, most recently from 9f841ac to 9339286 Compare January 23, 2024 02:59
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Dushusir
Copy link
Member Author

CC @Gggpound please check this test case

it('targetRange is overlap with range 2', () => {
                const range2 = { startRow: 10, endRow: 10, startColumn: 0, endColumn: 99 };
                const targetRange = { startRow: 10, endRow: 11, startColumn: 0, endColumn: 99 };
                const operators = handleIRemoveRow(
                    { params: { range: range2 }, id: EffectRefRangId.RemoveRowCommandId },
                    targetRange
                );
                const result = runRefRangeMutations(operators!, targetRange);
                expect(result).toEqual({ startRow: 10, endRow: 10, startColumn: 0, endColumn: 99 });
            });

@zhaolixin7
Copy link

移动公式选区后预期结果显示#ref
2024_2_2 14_29_18 video.webm

@Dushusir Dushusir closed this Mar 23, 2024
@Dushusir Dushusir deleted the dushusir/formula-offset-bug branch March 23, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants