-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formula): array formula update when ref-range changed #1134
Conversation
View Deployment
|
5e7132c
to
e543ac8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1134 +/- ##
=======================================
Coverage 29.59% 29.59%
=======================================
Files 841 841
Lines 47739 47739
Branches 9776 9776
=======================================
Hits 14127 14127
Misses 33612 33612 ☔ View full report in Codecov by Sentry. |
244fab4
to
2110121
Compare
e4dc4e7
to
368c642
Compare
After remove insert range, delete range, insert row/col |
After remove insert range, delete range |
9f841ac
to
9339286
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 9 New issues |
6720e48
to
7ef994e
Compare
9339286
to
f7999f2
Compare
CC @Gggpound please check this test case it('targetRange is overlap with range 2', () => {
const range2 = { startRow: 10, endRow: 10, startColumn: 0, endColumn: 99 };
const targetRange = { startRow: 10, endRow: 11, startColumn: 0, endColumn: 99 };
const operators = handleIRemoveRow(
{ params: { range: range2 }, id: EffectRefRangId.RemoveRowCommandId },
targetRange
);
const result = runRefRangeMutations(operators!, targetRange);
expect(result).toEqual({ startRow: 10, endRow: 10, startColumn: 0, endColumn: 99 });
}); |
移动公式选区后预期结果显示#ref |
Some details move to #1659
dev
branch.