Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(umd): create all-in-one UMD bundle #2062

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat(umd): create all-in-one UMD bundle #2062

merged 2 commits into from
Apr 25, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 24, 2024

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.04%. Comparing base (1f03b7a) to head (cdbcee4).

❗ Current head cdbcee4 differs from pull request most recent head f3f1b36. Consider uploading reports for the commit f3f1b36 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2062   +/-   ##
=======================================
  Coverage   31.04%   31.04%           
=======================================
  Files        1208     1208           
  Lines       66151    66151           
  Branches    13995    13995           
=======================================
  Hits        20537    20537           
  Misses      45614    45614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the feat/umd-bundle branch 4 times, most recently from e8c927d to 9ab1dbd Compare April 24, 2024 09:27
Copy link

github-actions bot commented Apr 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai force-pushed the feat/umd-bundle branch 2 times, most recently from f62c622 to 57a7eb8 Compare April 24, 2024 16:30
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Apr 25, 2024

Has this package been documented on the doc site?

@jikkai jikkai requested a review from yuhongz as a code owner April 25, 2024 13:41
@jikkai jikkai merged commit e76fe4e into dev Apr 25, 2024
8 of 9 checks passed
@jikkai jikkai deleted the feat/umd-bundle branch April 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants