Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon extension index should be higher than data-bar extension #2421

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

lumixraku
Copy link
Contributor

close #483
https://github.com/dream-num/univer-pro/issues/483

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku requested a review from Gggpound as a code owner June 5, 2024 03:33
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (c2b0019) to head (24d0760).

Files Patch % Lines
...nditional-formatting/src/render/data-bar.render.ts 0.00% 1 Missing ⚠️
...s-conditional-formatting/src/render/icon.render.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2421   +/-   ##
=======================================
  Coverage   27.09%   27.09%           
=======================================
  Files        1646     1646           
  Lines       83110    83110           
  Branches    17221    17221           
=======================================
  Hits        22520    22520           
  Misses      60590    60590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Jun 5, 2024
@lumixraku lumixraku merged commit ad7b3b5 into dev Jun 5, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/icon-render-zindex branch June 5, 2024 06:22
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 5, 2024
@DR-Univer DR-Univer restored the fix/icon-render-zindex branch June 19, 2024 08:11
@DR-Univer DR-Univer deleted the fix/icon-render-zindex branch June 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants