Update zio, zio-streams, zio-test, ... to 2.0.0 #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
amitksingh1490
force-pushed
the
update/zio-2.0.0
branch
from
28668b5
to
3f57150
Compare
|
Hi, |
|
I'm happy to help out with this PR if I can. |
tusharmath
reviewed
Jul 8, 2022
* added implementation for `cross` Gen combinator * added app and spec to izolate the issue * increased max message size in test app * for each strategy the executor should be set on ZIO program before executing the program. * attempt to fix compilation for scala 2.12 * removed test * removed cross
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
+ Coverage 60.30% 60.33% +0.02%
==========================================
Files 71 71
Lines 2532 2526 -6
Branches 73 77 +4
==========================================
- Hits 1527 1524 -3
+ Misses 1005 1002 -3
Continue to review full report at Codecov.
|
tusharmath
reviewed
Jul 8, 2022
| checkAll(Gen.fromIterable(LogLevel.all)) { level => | ||
| assertTrue(LogLevel.fromString(level.toString) == Some(level)) | ||
| } | ||
| }, | ||
| testM("any invalid value should not decode") { | ||
| test("any value with the exception of defined values for LogLevel should be set to Error log level.") { |
There was a problem hiding this comment.
description isn't right.
tusharmath
reviewed
Jul 8, 2022
|
|
||
| private def run[R, E](app: HttpApp[R, E]): ZIO[TestClock with R, Option[E], Response] = { | ||
| private def runApp[R, E](app: HttpApp[R, E]): ZIO[R, Option[E], Response] = { |
There was a problem hiding this comment.
Why is this change req?
tusharmath
reviewed
Jul 8, 2022
project/.bloop/zio-http-build.json
Outdated
| @@ -0,0 +1,1996 @@ | |||
| { | |||
There was a problem hiding this comment.
Why is this file added?
tusharmath
reviewed
Jul 8, 2022
| queue.takeUpTo(max).tap(as => ZIO.foreachDiscard(as)(f)) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Will review if there is a better way, to avoid this.
tusharmath
reviewed
Jul 8, 2022
tusharmath
reviewed
Jul 8, 2022
tusharmath
reviewed
Jul 8, 2022
tusharmath
reviewed
Jul 8, 2022
tusharmath
reviewed
Jul 8, 2022
tusharmath
reviewed
Jul 8, 2022
tusharmath
approved these changes
Jul 10, 2022
|
Is there a release with this coming? 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 1.0.15 to 2.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-major, semver-spec-major, commit-count:1