Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tooltip v1.0.16 (virtual-select dependency). Closes #673. #674

Merged
merged 2 commits into from Mar 8, 2024

Conversation

stla
Copy link
Contributor

@stla stla commented Mar 8, 2024

I also added the option all_files=FALSE in htmlDependency. I think you should always set this option, otherwise all files in the packer folder are included.

@pvictor
Copy link
Member

pvictor commented Mar 8, 2024

Hi,

Thanks for this. Isn't it possible to include those files directly in the bundle ?
You're right for the all_files arg, i'll put it in the other dependencies.

@stla
Copy link
Contributor Author

stla commented Mar 8, 2024

Thanks for this. Isn't it possible to include those files directly in the bundle ?

I don't know but I don't think so, because there's no such bundle on the download page.

@pvictor
Copy link
Member

pvictor commented Mar 8, 2024

I was thinking of something like :

import "tooltip-plugin/dist/tooltip.min.css";
import "tooltip-plugin/dist/tooltip.min.js";

here : https://github.com/dreamRs/shinyWidgets/blob/master/srcjs/inputs/virtual-select.js

which is the script that generate the one in inst/packer after calling packer::bundle()

@stla
Copy link
Contributor Author

stla commented Mar 8, 2024

Ah, I don't know sorry. I'm not familiar with import in JavaScript.

@pvictor pvictor merged commit 4300578 into dreamRs:master Mar 8, 2024
5 of 7 checks passed
@pvictor
Copy link
Member

pvictor commented Mar 8, 2024

I've modified the PR accordingly.
Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants