Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new workflow action and Fix cleanup bug #355

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Add new workflow action and Fix cleanup bug #355

merged 6 commits into from
Jul 19, 2024

Conversation

tqjason
Copy link
Contributor

@tqjason tqjason commented Jul 19, 2024

  1. Add new workflow action, Deploy Frontend with page function
  2. Fix a cleanup bug. It throw error when cleanDays is 0

@tqjason
Copy link
Contributor Author

tqjason commented Jul 19, 2024

直接在github web上修改测试的，所以 commits 比较乱了

@tqjason
Copy link
Contributor Author

tqjason commented Jul 19, 2024

另外，清理天数 这里有点文字上的歧义，代码是清理 n 天之前的邮件，直接叫清理天数，以为是清理最近 n 天的邮件

@dreamhunter2333
Copy link
Owner

dreamhunter2333 commented Jul 19, 2024 •
edited
Loading

另外，清理天数 这里有点文字上的歧义，代码是清理 n 天之前的邮件，直接叫清理天数，以为是清理最近 n 天的邮件

确实有歧义，目前的修改看起来可以清理 0 天，我修改下翻译

@dreamhunter2333 dreamhunter2333 merged commit 38816cb into dreamhunter2333:main Jul 19, 2024
@tqjason
Copy link
Contributor Author

tqjason commented Jul 19, 2024

高兴，合并后我就可以直接 fork 过来了

@tqjason
Copy link
Contributor Author

tqjason commented Jul 19, 2024

可能使用说明中需要加上 action secret PAGE_TOML 的内容

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamhunter2333 dreamhunter2333 dreamhunter2333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tqjason @dreamhunter2333