Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select engine in querystring #18

Merged
merged 6 commits into from Aug 6, 2020
Merged

Select engine in querystring #18

merged 6 commits into from Aug 6, 2020

Conversation

UnicodingUnicorn
Copy link
Contributor

Should resolve #15. In light of PR #16, retrieving parameters from the querystring is now a thing.

dreampuf
dreampuf approved these changes Aug 6, 2020
View reviewed changes
Copy link
Owner

@dreampuf dreampuf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't like the extend of HTMLOptionsCollection, It works. Thanks!

@dreampuf dreampuf merged commit 15d82b6 into dreampuf:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreampuf dreampuf dreampuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify the engine via the url
2 participants
@UnicodingUnicorn @dreampuf