feat/336 : check if pandas df and drop_last default to True #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimox
force-pushed
the
feat/error-for-pandas
branch
from
483faf4
to
7ff83d7
Compare
Optimox
force-pushed
the
feat/error-for-pandas
branch
from
7ff83d7
to
b45ed15
Compare
eduardocarvp
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
This adds a test for a clear error when input pandas dataframe when calling fit.
This has not been tested (blind coded please test before merging)
This PR also switch drop_last default value to True
What needs to be documented once your changes are merged?
Nothing
Closing issues
closes #335 and closes #336
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).