feat: add attentive embeddings #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimox
force-pushed
the
feature/embedding-attention
branch
4 times, most recently
from
61cbf1f
to
c8bd369
Compare
Optimox
force-pushed
the
feature/embedding-attention
branch
from
c8bd369
to
114b383
Compare
|
Just to point out, the torch-scatter dependency introduced here is making it a bit tricky for me to reproduce the Forest Cover Type tests from #217 because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
What kind of change does this PR introduce?
This PR aims at improving attention with embeddings.
As the embedding size grows the attention module becomes less relevant, because attention does not know about what columns are from the same embeddings.
In order to solve this problem, this PR adds a mask post processing that takes (for now) the max of attention given to any embedding (mean could be tried as well).
Does this PR introduce a breaking change?
Everything is internal and invisible to the end users.
What needs to be documented once your changes are merged?
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).