Set feature importance tensor size according to embedding dimensions (TabNetRegressor) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in TabNetRegressor.train_epoch Fix tensor shape issues when `cat_emb_dim>1` with `TabNetRegressor`. This issue was fixed for TabNetClassifier in dreamquark-ai#48 but not for the regressor.
|
oh thank you sorry I did not see your PR, I have spotted this omission as well (and did a PR, but will review yours instead). |
|
I merged my PR #96 since I made a few changes to the notebooks so that this bug would pop when running them if it comes again! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix tensor shape issues when
cat_emb_dim>1inTabNetRegressor.This issue was fixed for
TabNetClassifierin #48 but it was not the for the regressor (probably an omission?).Does this PR introduce a breaking change?
Not that I know of.
input_dimshould be equal tonetwork.post_embed_dimwhencat_emb_dim=1.What needs to be documented once your changes are merged?
Nothing more.
Closing issues
closes #49