Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added window_zoomed_flag to show_directory_in_window_status_current #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stracaganasse
Copy link

@stracaganasse stracaganasse commented Jun 27, 2023

Felt like it happened very often that i missed the context of having a pane zoomed in.
=> Added a unicode char (respecting active window colour palette) and showing IFF window_zoomed_flag is 1

Might be better to add a whole new
show_directory_and_zoom_in_window_status_current
to have a clean selection but could be an overcomplication.

Choice of unicode char was optimal on my screen/fontsize, should be easy enough to switch it for unicode supporting terminals.

Very unsure as if this PR process is ok by me and follows common etiquette, this would be my first PR ever. Apologies if I'm out of order.

Screenshot_20230627_235232

@slockers37
Copy link

Yes please merge this into the plugin. I am also looking for it.

@Knackii
Copy link

Knackii commented Jan 2, 2024

I tried your branch and it doesn't work anymore I think, when zooming a pane it doesn't show anything special on my side...

@stracaganasse
Copy link
Author

@Knackii it's been a while since i touched this so the specific syntax slips my mind.

Without any additional context it's hard to envision the nature of the bug.
As of now my PR works on my machine, but i have not touched the whole environment in any way; there may have been updates to tmux that i know nothing of.

possible checks

  • The first check that I could recommend would be making sure that your terminal can handle the unicode character i chose:

  • Depending on that you can change it with a normal ASCII char of your choice and see if it displays correctly in that case

You can try editing the (original) interested .tmux file directly with the code in my PR if you haven't already and see if anything changes.

disclaimer

All of this with the caveat of correctly sourcing the configuration via tmux source ~/path/to/your/tmux.conf after each change.
I also assume that the original conf worked without issues on your machine, that may not be the case.

@Knackii
Copy link

Knackii commented Jan 2, 2024

Oops, I think it's because I tried on your repo without specifying the branch your feature is on 😅 I assumed it was on your main but I didn't see you did a PR from one of your other branches... It's still not working because I have another issue but it's not related to that I think..

@elliottminns
Copy link
Member

Sorry for the delay on reviewing this. My GH notifications are finally fixed.

I like this feature a lot and will aim to merge it in. Ideally if we can configure it somehow that way anyone using it who doesn't want to isn't affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants