Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit all uses of "http:" #1246

Closed
afuna opened this issue Feb 25, 2015 · 3 comments
Closed

audit all uses of "http:" #1246

afuna opened this issue Feb 25, 2015 · 3 comments
Assignees
@afuna
Labels
status: claimed status: untriaged
Milestone
HTTPS Everywhere v1

Comments

@afuna
Copy link
Member

afuna commented Feb 25, 2015

Example: redirecting to another page if the URL does not check out (where we mistakenly redirect because we're only checking for "http://" instead of "https?://"
@afuna afuna added this to the HTTPS Everywhere v1 milestone Feb 25, 2015
@afuna afuna self-assigned this Feb 25, 2015
@afuna
Copy link
Member Author

afuna commented Feb 25, 2015

Otherwise we get into hilarious cases like trying to access /profile doing an infinite redirect loop.

@rahaeli
Copy link
Contributor

rahaeli commented Feb 25, 2015

ahahahaha that sounds like the tiny despairing voice of "....but why is that HAPPENING?" speaking

@afuna afuna changed the title audit all checks for "http" audit all uses of "http:" Feb 25, 2015
afuna added a commit to afuna/dw-free that referenced this issue Feb 26, 2015
@afuna
[dreamwidth#1246] Check for https as well as http when checking urls
cb2ae4f 
Fixes dreamwidth#1246.
afuna added a commit to afuna/dw-free that referenced this issue Feb 26, 2015
@afuna
[dreamwidth#1246] Make sure generated URLs use https when appropriate
2953707
@afuna
Copy link
Member Author

afuna commented Feb 26, 2015

Noting here that I've also looked at the $*font_sources (which have as values external stylesheet urls) and these are all fine because they go through the cssproxy.

afuna added a commit to afuna/dw-free that referenced this issue Feb 26, 2015
@afuna
[dreamwidth#1246] Make sure generated URLs use https when appropriate
40e7f79
afuna added a commit to afuna/dw-free that referenced this issue Feb 26, 2015
@afuna
[dreamwidth#1246] Remove obsolete file
80462df
@afuna afuna closed this as completed in 9a39f5b Feb 26, 2015
zorkian added a commit that referenced this issue Feb 26, 2015
@zorkian
Merge pull request #1247 from afuna/http-check-bug-1246
f0d1368 
[#1246] Check for https as well as http; use https for generated urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afuna afuna

Labels
status: claimed status: untriaged
Milestone
HTTPS Everywhere v1
Development

No branches or pull requests
3 participants
@afuna @rahaeli @robodw-issues