Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entry success page should not show metadata when deleting entry #1445

Closed
rahaeli opened this issue Jun 26, 2015 · 3 comments
Closed

entry success page should not show metadata when deleting entry #1445

rahaeli opened this issue Jun 26, 2015 · 3 comments
Assignees
@kaberett
Labels
effort: (1) lower is: bug severity: (1) minor status: claimed

Comments

@rahaeli
Copy link
Contributor

rahaeli commented Jun 26, 2015

The new entry metadata on the success screen is still showing when you delete an entry, not just on post or edit. :)
@woggy
Copy link
Contributor

woggy commented Jun 29, 2015

Unsure whether to make an entirely new issue for this, but also. The subject line would be more helpful if it said "no subject" explicitly. Will likely fix the two in the same pullreq, so.

@kaberett
Copy link
Contributor

kaberett commented Aug 6, 2015

Oh wait, I've actually fixed the metadata-on-deletion issue, just not all the other bits and bobs. Okay, might as well get the pull req in and open another issue for the other bits that've been discussed.

kaberett added a commit to kaberett/dw-free that referenced this issue Aug 6, 2015
@kaberett
Remove extra info on deletion success
13eb346 
When entries have been deleted they don't need extra data
for security and subject.

Fixes dreamwidth#1445.
@kaberett kaberett mentioned this issue Aug 6, 2015
Merged
@kaberett
Copy link
Contributor

kaberett commented Aug 6, 2015

(I took this one over with @woggy's blessing!)

@kareila kareila assigned kaberett and unassigned woggy Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaberett kaberett

Labels
effort: (1) lower is: bug severity: (1) minor status: claimed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rahaeli @kaberett @woggy