Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari+JS] problem with input focus on /rename page #1504

Closed
kareila opened this issue Aug 1, 2015 · 3 comments · Fixed by #1505
Closed

[Safari+JS] problem with input focus on /rename page #1504

kareila opened this issue Aug 1, 2015 · 3 comments · Fixed by #1505

Comments

@kareila
Copy link
Member

kareila commented Aug 1, 2015

If I visit dreamwidth.org/rename and try to input text into the "Rename token" text field, the focus immediately jumps up to the "Desired username" field. Using control-click to paste text is the only workaround I've figured out so far.

I'm only able to reproduce this in Safari. If I use Firefox or Chrome, the focus doesn't jump away. I haven't checked to see if earlier versions of Safari are affected, but the same thing seems to happen in Safari on my iPad running iOS 8.3 as well.

There's no special JavaScript being loaded on the page, just the default site-wide stuff.

@afuna
Copy link
Member

afuna commented Aug 1, 2015 via email

@rahaeli
Copy link
Contributor

rahaeli commented Aug 1, 2015

Confirming in 6.2.7 (8537.85.16.12)

On Aug 1, 2015, at 12:54 AM, Jen notifications@github.com wrote:

If I visit dreamwidth.org/rename and try to input text into the "Rename token" text field, the focus immediately jumps up to the "Desired username" field. Using control-click to paste text is the only workaround I've figured out so far.

I'm only able to reproduce this in Safari. If I use Firefox or Chrome, the focus doesn't jump away. I haven't checked to see if earlier versions of Safari are affected, but the same thing seems to happen in Safari on my iPad running iOS 8.3 as well.

There's no special JavaScript being loaded on the page, just the default site-wide stuff.


Reply to this email directly or view it on GitHub.

@kareila
Copy link
Member Author

kareila commented Aug 1, 2015

Confirming that closing the labels (neither was closed!) fixes the issue in my testing. Will submit the fix shortly.

kareila added a commit to kareila/dreamwidth that referenced this issue Aug 1, 2015
Two label tags were unclosed, leading to JS focus problems in Safari.

Closing the labels caused them to add line breaks.  Added in-page
"display: inline" styling to keep the line unbroken.

Fixes dreamwidth#1504.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants