Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entries deleted via http://www.dreamwidth.org/editjournal offer the option to "Edit this entry again" on Success page #1613

Closed
kaberett opened this issue Nov 7, 2015 · 5 comments
Closed

Entries deleted via http://www.dreamwidth.org/editjournal offer the option to "Edit this entry again" on Success page #1613

kaberett opened this issue Nov 7, 2015 · 5 comments
Assignees
@kaberett
Labels
status: claimed status: untriaged

Comments

@kaberett
Copy link
Contributor

kaberett commented Nov 7, 2015

They shouldn't.
@kaberett
Copy link
Contributor Author

kaberett commented Nov 7, 2015

claim

@kaberett
Copy link
Contributor Author

kaberett commented Nov 7, 2015

... https://github.com/dreamwidth/dw-free/blob/develop/htdocs/editjournal.bml line 369 already has "unless $deleted" next to where that line gets printed. That's exciting.

@me-and
Copy link
Contributor

me-and commented Nov 7, 2015

So yes, line 369 has unless $deleted on it. But that's the line that's printing .success.fromhere.viewentry.

The line that's printing .success.fromhere.editentry is missing that, and that's probably why the bug.

@kaberett
Copy link
Contributor Author

kaberett commented Nov 7, 2015

:(

@me-and
Copy link
Contributor

me-and commented Nov 7, 2015

Yay, you pulled a face. I call that success.

kaberett added a commit to kaberett/dw-free that referenced this issue Nov 7, 2015
@kaberett
Don't suggest editing deleted entries
a2383e9 
Fixes dreamwidth#1613.
@kaberett kaberett mentioned this issue Nov 7, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaberett kaberett

Labels
status: claimed status: untriaged
Milestone
No milestone
Development

No branches or pull requests
3 participants
@me-and @kaberett @robodw-issues