Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether IP::Country::Fast is still needed #2179

Closed
pauamma opened this issue May 14, 2017 · 2 comments
Closed

Check whether IP::Country::Fast is still needed #2179

pauamma opened this issue May 14, 2017 · 2 comments

Comments

@pauamma
Copy link
Contributor

pauamma commented May 14, 2017

The only grep hit I see is in bin/checkconfig.pl, and there's also a reference in http://wiki.dreamwidth.net/wiki/index.php/Dreamwidth_Scratch_Installation#Install_Perl_modules_with_CPAN .

@Sophira
Copy link
Contributor

Sophira commented May 14, 2017

I was the one who added IP::Country::Fast to that wiki page just over a month ago, and I did so based on the output of bin/checkconfig.pl. So it's possible that that reference only exists there because it was in the config checker. I'll take a look around and see where it comes from.

@Sophira
Copy link
Contributor

Sophira commented May 14, 2017

So it seems IP::Country::Fast was used by the LJ code when we forked (in the Writer's Block feature), but along the way Writer's Block was removed (commit 5b19bf1) and then later the function that actually used IP::Country::Fast disappeared too (commit 2486cf7).

We should be able to remove the check from checkconfig.pl without issue, so far as I can see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants