Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide 'track thread' icon from free users in comments #691

Closed
ninetyd opened this issue Apr 2, 2014 · 2 comments · Fixed by #703
Closed

Hide 'track thread' icon from free users in comments #691

ninetyd opened this issue Apr 2, 2014 · 2 comments · Fixed by #703

Comments

@ninetyd
Copy link

ninetyd commented Apr 2, 2014

We've had several requests from confused users who thought they weren't getting some notifications only to realize their account status didn't allow them to track comment threads. However, they can see the track icon and they can add the notification and nothing tells them it won't work. The icon at least should be hidden from them.

@ninetyd
Copy link
Author

ninetyd commented Apr 2, 2014

Here's one of the requests: http://www.dreamwidth.org/support/see_request?id=25671

@rahaeli rahaeli added this to the Unclaimed milestone Apr 2, 2014
@rahaeli
Copy link
Contributor

rahaeli commented Apr 21, 2014

Implementation note: I've looked into this a bit, and when you hit the bell "track this" icon on a comment, you only get the "email me when someone replies to this thread". (I thought it gave the option of both tracking the thread and tracking the comments on the whole post.)

So, it should be OK to just hide the bell icon when an account doesn't have access to track threads. (And it's probably best to add a "can_track_comment_threads" method in User.pm and check it that way, rather than directly checking paid status, if there isn't one already.)

hotlevel4 added a commit to hotlevel4/dw-free that referenced this issue Apr 22, 2014
Checks whether a user can track threads before displaying tracking icon.
afuna added a commit that referenced this issue Apr 22, 2014
(Issue #691) Hide 'track thread' icon from free users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants