[#1113] Show the read comments link when you reply via QR

[afuna]

-- this is for the case where we go from 0 -> 1 comment, and we used to
not display a link (because we had nothing to display)

Fixes #1113.

[afuna]

Hmm, might need to think about this a bit more. This means that layouts that aren't based on core2 will suddenly have "0 comments" all over their read page.

[afuna]

pls to feedback if able, but don't merge yet. thanks!

[zorkian]

Ah so the goal here is that when you QR on your reading page, you want the comments link to appear? That sounds good, but I definitely agree that we shouldn't show the "0 comments" text to everybody -- that seems funky.

[zorkian]

PS marking as changes requested to block merging.

[afuna]

Figured out how to make this work for core2 styles without affecting custom styles that haven't been updated: use a different variable. Removing label as this one is suitable for review and/or merge.

[afuna]

Hey also -- do we care about labelling pull requests? I mostly focus on labelling the issues and haven't paid attention to the associated pull requests.

[zorkian]

What do you mean labeling?

Mark Smith mark@qq.is

On Wed, Mar 4, 2015, at 10:19 AM, Afuna wrote:

Hey also -- do we care about labelling pull requests? I mostly focus
on labelling the issues and haven't paid attention to the associated
pull requests.

— Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)

[afuna]

Adding the severity, etc.

On Wed, Mar 4, 2015, at 11:50 AM, Mark Smith wrote:

What do you mean labeling?

Mark Smith mark@qq.is

On Wed, Mar 4, 2015, at 10:19 AM, Afuna wrote:

Hey also -- do we care about labelling pull requests? I mostly focus

on labelling the issues and haven't paid attention to the associated

pull requests.

— Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)
   — Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)

[zorkian]

Since I only am looking at Pull Requests, I think it's useful to add
them?

Mark Smith mark@qq.is

On Wed, Mar 4, 2015, at 12:07 PM, Afuna wrote:

Adding the severity, etc.

On Wed, Mar 4, 2015, at 11:50 AM, Mark Smith wrote:

What do you mean labeling?

Mark Smith mark@qq.is

On Wed, Mar 4, 2015, at 10:19 AM, Afuna wrote:

Hey also -- do we care about labelling pull requests? I mostly focus

on labelling the issues and haven't paid attention to the associated

pull requests.

— Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)

— Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)
   — Reply to this email directly or view it on GitHub[1].

Links:

1. [#1113] Show the read comments link when you reply via QR #1270 (comment)

[afuna]

Okay!

[zorkian]

This introduces a new option? Hrmm, why?

You mention backwards compatibility with old styles. Is there really no way to do it with CSS/JS that makes it work for them without forcing people to update their style to turn this variable on?

[zorkian]

Oh nevermind, it's entirely internal; when they recompile they'll get it.