Add notice about performance

drecom · Jan 7, 2015 · 3f84bce · 3f84bce
1 parent 5811bdd
commit 3f84bce
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/active_record/turntable/active_record_ext/association.rb b/lib/active_record/turntable/active_record_ext/association.rb
@@ -38,7 +38,7 @@ def get_records_with_turntable
                 scope.eager_loading? ||
                 klass.current_scope ||
                 klass.default_scopes.any? ||
-                should_use_shard_key?
+                should_use_shard_key? # OPTIMIZE: Use bind values if cachable scope
 
               return turntable_scope(scope).limit(1).to_a
             end
@@ -86,7 +86,7 @@ def get_records_with_turntable
                 scope.eager_loading? ||
                 klass.current_scope ||
                 klass.default_scopes.any? ||
-                should_use_shard_key?
+                should_use_shard_key? # OPTIMIZE: Use bind values if cachable scope
 
               return turntable_scope(scope).to_a
             end