Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate PoolProxy from owner_to_pool #83

Conversation

gussan
Copy link
Collaborator

@gussan gussan commented Nov 8, 2018

to prevent duplicated connection handling method calls when releasing connections
that causes performance degradation.

All of ConnectionAdapter objects are included in owner_to_pool natively,
so it doesn't have to include PoolProxy objects.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

@coveralls
Copy link

coveralls commented Nov 8, 2018

Coverage Status

Coverage decreased (-0.02%) to 91.318% when pulling 7c9e4a5 on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.3% when pulling f4d8bdf on feature/separate_turntable_pool_proxies_from_normal_owner_to_pool into 3bd414b on master.

to prevent duplicated connection handling method calls when releasing connections
that causes performance degradation.

All of ConnectionAdapter objects are included in `owner_to_pool` natively,
so it doesn't have to include PoolProxy objects.
@gussan gussan force-pushed the feature/separate_turntable_pool_proxies_from_normal_owner_to_pool branch from f4d8bdf to 7c9e4a5 Compare November 12, 2018 01:24
@gussan gussan merged commit 6469c99 into master Nov 12, 2018
@gussan gussan deleted the feature/separate_turntable_pool_proxies_from_normal_owner_to_pool branch November 12, 2018 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants