Beeminder integration bugfix for when TT is being run on multiple machines #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver. For TT there should be only one datapoint per day on the beeminder server. The way things were being handled, duplicates were being deleted from the data fetched from the server, but the resulting empty entry in the array was sometimes causing a (different) duplicate to be re-created later in the script. This bug would only normally show up under circumstances where two copies of TagTime were writing to the same graph, for example when it is being run on two machines simultaneously. This commit changes the deletion method to result in no duplicate entries being created.
dreeves
added a commit
that referenced
this pull request
Jan 16, 2014
Beeminder integration bugfix for when TT is being run on multiple machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix, coupled with a FIXME on ttlogmerge which was the subject of my last merge request. It is part of an ongoing effort to make TagTime co-operate seamlessly when run on multiple machines at once.