Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/scroll reveal unittests #17

Merged
merged 8 commits into from
Feb 15, 2019
Merged

Feature/scroll reveal unittests #17

merged 8 commits into from
Feb 15, 2019

Conversation

faebeee
Copy link
Contributor

@faebeee faebeee commented Feb 15, 2019

No description provided.

@GianlucaGuarini
Copy link
Contributor

the unit test fails

@GianlucaGuarini
Copy link
Contributor

I have done a couple of updates:

  • fixed the unit test
  • renamed the events dispatched in order make them consistent with events dispatched by the other components some-event-name
  • added the destroy method when the scroll reveal element will be removed

@GianlucaGuarini GianlucaGuarini merged commit a64cd79 into master Feb 15, 2019
@GianlucaGuarini GianlucaGuarini deleted the feature/scroll-reveal-unittests branch February 15, 2019 16:06
@coveralls
Copy link

coveralls commented Feb 15, 2019 •
edited

Pull Request Test Coverage Report for Build 229

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 70.857%
Totals Coverage Status
Change from base Build 222: 0.9%
Covered Lines: 182
Relevant Lines: 231
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GianlucaGuarini GianlucaGuarini Awaiting requested review from GianlucaGuarini

Assignees

@GianlucaGuarini GianlucaGuarini

Labels
ACK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@faebeee @GianlucaGuarini @coveralls