Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/esm transpiled dist #27

Merged
merged 4 commits into from Apr 24, 2019
Merged

Feature/esm transpiled dist #27

merged 4 commits into from Apr 24, 2019

Conversation

GianlucaGuarini
Copy link
Contributor

Simplify the modules import and make sure that all the submodules will be transpiled

@GianlucaGuarini GianlucaGuarini changed the base branch from master to develop April 23, 2019 14:18
@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited

Pull Request Test Coverage Report for Build 327

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.908%
Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 258
Relevant Lines: 288
💛 - Coveralls

nirazul
nirazul approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@nirazul nirazul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only concern that I have: Will we lose treeshaking capability? I guess so, right?

@GianlucaGuarini
Copy link
Contributor Author

yes i can give rollup another chance. Let me try quickly

@GianlucaGuarini GianlucaGuarini force-pushed the feature/esm-transpiled-dist branch 2 times, most recently from 376d27d to 83e9293 Compare April 24, 2019 09:18
@GianlucaGuarini GianlucaGuarini merged commit 891f13b into develop Apr 24, 2019
@GianlucaGuarini GianlucaGuarini deleted the feature/esm-transpiled-dist branch April 24, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirazul nirazul nirazul approved these changes

Assignees

@nirazul nirazul

Labels
ACK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GianlucaGuarini @coveralls @nirazul