Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults.retention-count and defaults.retention-age are not applied #19

Open
schakko opened this issue Oct 12, 2023 · 1 comment
Open
Assignees
Labels
documentation Improvements or additions to documentation housekeeping

Comments

@schakko
Copy link
Contributor

schakko commented Oct 12, 2023

In backup definition documentation it is described that the following configuration is allowed:

'./databases/{{client}}':
  defaults:
    retention-count: 10
    retention-age: 7d

But that configuration does not have any effects on Prometheus metrics backmon_backup_file_count_aim and backmon_backup_file_age_aim_seconds (also probably backmon_backup_latest_creation_aim_seconds).
retention-count and retention-age can only be directly applied below the files: section.

Either change the documentation or change the behavior.

I've added a reference to this task in backup definition documentation. It must be remoed after we have decided how to deal with this issue.

@schakko schakko added documentation Improvements or additions to documentation housekeeping labels Oct 12, 2023
@schakko schakko self-assigned this Oct 12, 2023
schakko added a commit to dreitier/backmon-docs that referenced this issue Oct 12, 2023
Signed-off-by: Christopher Klein <ckl@dreitier.com>
@thomashoell
Copy link
Contributor

In https://github.com/dreitier/backmon/blob/main/storage/storage.go#L307 only the file definitions are taken into account. To fix this, the defaults need to be passed down to the files section if the corresponding parameters (retention age/count) are not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation housekeeping
Projects
None yet
Development

No branches or pull requests

2 participants