Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vietnamese language for RetroBar #160

Merged
merged 7 commits into from Nov 12, 2021
Merged

Add Vietnamese language for RetroBar #160

merged 7 commits into from Nov 12, 2021

Conversation

michioxd
Copy link
Contributor

Add Vietnamese (Tiếng Việt) language for RetroBar

@michioxd michioxd changed the title Update Vietnamese Language Add Vietnamese language for RetroBar Nov 11, 2021
@xoascf
Copy link
Collaborator

xoascf commented Nov 11, 2021

You need to correct the name for the language to be used for the System to "Tiếng Việt" (Tiếng Việt.xaml).
Also, you will need to remove the references to "properties_95" and "properties_95_noclock" if you do not have the images localised for your language.

@michioxd
Copy link
Contributor Author

Did you mean correct the title of this pull?
Also I removed the references "properties_95" and "properties_95_noclock" as you said, thanks!

@xoascf
Copy link
Collaborator

xoascf commented Nov 12, 2021

Did you mean correct the title of this pull?

No, I am referring to the .xaml translation file, curiously the first letter e does not match the correct diacritic of the language name (at least the one used by Windows), you can compare it with the result of the command:
powershell [System.Globalization.CultureInfo]::CurrentUICulture.Parent.NativeName
If the language name is different even by one character, the language is not automatically loaded by RetroBar with that language name (this when "System" is chosen as language, and the system uses that language).

@michioxd
Copy link
Contributor Author

Ok thanks it work!

@dremin
Copy link
Owner

dremin commented Nov 12, 2021

Awesome, thanks!

@dremin dremin merged commit 9658067 into dremin:master Nov 12, 2021
@xoascf xoascf added the localization Translations or localization-related issues label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Translations or localization-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants