Skip to content

Commit

Permalink
Release 1.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
laurentgo committed Aug 15, 2017
1 parent 7709621 commit 57889fb
Show file tree
Hide file tree
Showing 463 changed files with 8,395 additions and 4,126 deletions.
56 changes: 56 additions & 0 deletions CONTRIBUTING.md
@@ -0,0 +1,56 @@
Contributing to Dremio
===================

Thank you for your interest in contributing to Dremio.

This document summarizes the different ways you can contribute.

Feature requests and bug reports
-----------------------------------------------

If you believe you have found an issue in Dremio, or have an idea for a feature missing in our software, you might not be alone. Please start by searching https://community.dremio.com and check if someone else has already reported it.

If you're the first one to report a bug, please include as much information as possible, so we can diagnose and possibly reproduce:

- Dremio version, available under `Help > About Dremio` (please try to reproduce the issue with the latest available version, as it might have already been fixed)
- OS (`uname -a` output on Unix platforms, or equivalent for Windows)
- Java version (`java -version`)
- Information about the query: the query itself, the query profile, the data sources, and any other information you can provide that might be helpful
- If queried data is public, a link to it
- Stacktrace from the logs

For a feature request, please create a new topic describing the feature, what it is supposed to do, and why you need it. If someone else already created a topic for it, please contribute to the discussion.

Contributing code and documentation changes
-------------------------------------------

Here are the recommended steps if you are ready to contribute code or a documentation change:

### Verify if someone else already proposed the same change

Check https://community.dremio.com and https://github.com/dremio/dremio-oss/pulls to see if someone is already working on it.

### Fork and clone the repository

You will need to fork `dremio-oss` repository and clone it to your local machine. See
[github help page](https://help.github.com/articles/fork-a-repo) for help.

Instructions on how to build Dremio are available in the [README.md](https://github.com/dremio/dremio-oss/README.md) file at the root of the repository.

Make sure Dremio can still build and tests pass after your changes (Note: some tests might fail on your environment: please mention them in your pull request)

### Open a pull request

Once your changes are ready to be submitted:

1. Sign the CLA (Contributor License Agreement)

Please make sure you have signed our [Contributor License Agreement](https://www.dremio.com/legal/contributor-agreement/), which enables Dremio to distribute your contribution without restriction.

2. Submit a pull request

Push your local changes to your forked copy of the repository and [submit a pull request](https://help.github.com/articles/using-pull-requests). Don't forget to choose a title for your change, and don't hesitate to add details in your description.

3. Reply to feedback and wait
You will probably be contacted by a Dremio team member regarding your changes, with some questions and possibly some suggestions or change requests. If everything looks good (and CLA is signed), your contribution will be merged in our internal repository, and available in `dremio-oss` repository with our next release.

2 changes: 1 addition & 1 deletion client/jdbc/pom.xml
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>com.dremio.client</groupId>
<artifactId>dremio-client-parent</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>
<artifactId>dremio-client-jdbc</artifactId>
<name>Client - JDBC Driver</name>
Expand Down
2 changes: 1 addition & 1 deletion client/pom.xml
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.dremio</groupId>
<artifactId>dremio-root</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<groupId>com.dremio.client</groupId>
Expand Down
2 changes: 1 addition & 1 deletion common/pom.xml
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>com.dremio</groupId>
<artifactId>dremio-root</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<artifactId>dremio-common</artifactId>
Expand Down
@@ -1,14 +1,12 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
* <p>
* http://www.apache.org/licenses/LICENSE-2.0
* <p>
/*
* Copyright (C) 2017 Dremio Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Expand Down
7 changes: 5 additions & 2 deletions common/src/main/java/com/dremio/common/utils/PathUtils.java
Expand Up @@ -42,7 +42,8 @@ public class PathUtils {
private static final char PATH_DELIMITER = '.'; // dot separated path
private static final Joiner KEY_JOINER = Joiner.on(PATH_DELIMITER).useForNull("");
private static final String SLASH = Path.SEPARATOR;
private static final Joiner PATH_JOINER = Joiner.on(SLASH.charAt(0)).useForNull("");
private static final char SLASH_CHAR = Path.SEPARATOR_CHAR;
private static final Joiner PATH_JOINER = Joiner.on(SLASH_CHAR).useForNull("");
private static final Path ROOT_PATH = new Path(SLASH);
private static final List<String> EMPTY_SCHEMA_PATHS = Collections.emptyList();

Expand Down Expand Up @@ -149,7 +150,9 @@ public static List<String> toPathComponents(String fsPath) {
if (fsPath == null ) {
return EMPTY_SCHEMA_PATHS;
}
return Splitter.on(SLASH).omitEmptyStrings().splitToList(fsPath);

final StrTokenizer tokenizer = new StrTokenizer(fsPath, SLASH_CHAR, SqlUtils.QUOTE).setIgnoreEmptyTokens(true);
return tokenizer.getTokenList();
}

/**
Expand Down
Expand Up @@ -25,6 +25,8 @@
import org.apache.commons.io.output.ByteArrayOutputStream;

import com.dremio.common.exceptions.UserException;
import com.fasterxml.jackson.core.JsonEncoding;
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.JsonParser;

import io.protostuff.GraphIOUtil;
Expand Down Expand Up @@ -108,7 +110,10 @@ public static <T> T fromJSON(String data, Schema<T> schema, boolean numeric) thr
*/
public static <T> void toJSON(OutputStream out, T message, Schema<T> schema,
boolean numeric) throws IOException {
JsonIOUtil.writeTo(out, message, schema, numeric);
try (JsonGenerator jsonGenerator =
JsonIOUtil.DEFAULT_JSON_FACTORY.createGenerator(out, JsonEncoding.UTF8).disable(JsonGenerator.Feature.QUOTE_NON_NUMERIC_NUMBERS)) {
JsonIOUtil.writeTo(jsonGenerator, message, schema, numeric);
}
}

/**
Expand Down
14 changes: 9 additions & 5 deletions common/src/main/java/com/dremio/config/DremioConfig.java
Expand Up @@ -78,13 +78,11 @@ public class DremioConfig extends NestedConfig {
*/
public static final String WEB_UI_SERVICE_CONFIG = "services.coordinator.web.ui";

/**
* Path where debug options are located
*/
public static final String DEBUG_OPTIONS = "debug";

public static final String CLIENT_PORT_INT = "services.coordinator.client-endpoint.port";
public static final String SERVER_PORT_INT = "services.fabric.port";

public static final String AUTOUPGRADE = "services.coordinator.auto-upgrade";

public static final String REGISTRATION_ADDRESS = "registration.publish-host";
public static final String DB_PATH_STRING = "paths.db";
public static final String ACCELERATOR_PATH_STRING = "paths.accelerator";
Expand All @@ -95,6 +93,12 @@ public class DremioConfig extends NestedConfig {
public static final String SPILLING_PATH_STRING = "paths.spilling";

public static final String ZOOKEEPER_QUORUM = "zookeeper";

/**
* Path where debug options are located
*/
public static final String DEBUG_OPTIONS = "debug";

// to enable remote debugging of the DremioDaemon running in YARN container
public static final String DEBUG_YARN_ENABLED = "debug.yarnremote.enabled";
public static final String YARN_HEAP_SIZE = "provisioning.yarn.heapsize";
Expand Down
3 changes: 3 additions & 0 deletions common/src/main/resources/dremio-reference.conf
Expand Up @@ -55,6 +55,9 @@ services: {
coordinator: {
enabled: true,

# Auto-upgrade Dremio at startup if needed
auto-upgrade: false,

embedded_master_zk: {
enabled: true,
port: 2181,
Expand Down
Expand Up @@ -36,6 +36,7 @@ public class TestPathUtils {
public void testPathComponents() throws Exception {
assertEquals(ImmutableList.of("a", "b", "c"), PathUtils.toPathComponents(new Path("/a/b/c")));
assertEquals(ImmutableList.of("a", "b", "c"), PathUtils.toPathComponents(new Path("a/b/c")));
assertEquals(ImmutableList.of("a", "b", "c/"), PathUtils.toPathComponents(new Path("a/b/\"c/\"")));
}

@Test
Expand Down
Expand Up @@ -129,5 +129,14 @@ public void testNanSerialization() throws IOException {
foo.bar = Double.NaN;

assertThat(ProtostuffUtil.toJSON(foo, SCHEMA, false), CoreMatchers.containsString("NaN"));
assertThat(ProtostuffUtil.toJSON(foo, SCHEMA, false), CoreMatchers.not(CoreMatchers.containsString("\"NaN\"")));
}

@Test
public void testNanSerDe() throws IOException {
Foo foo = new Foo();
foo.bar = Double.NaN;

assertEquals(Double.NaN, ProtostuffUtil.fromJSON(ProtostuffUtil.toJSON(foo, SCHEMA, false), SCHEMA, false).bar, 0);
}
}
2 changes: 1 addition & 1 deletion contrib/hive-exec-shade/pom.xml
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.dremio.contrib</groupId>
<artifactId>dremio-contrib-parent</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<artifactId>dremio-hive-exec-shaded</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion contrib/pom.xml
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.dremio</groupId>
<artifactId>dremio-root</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<groupId>com.dremio.contrib</groupId>
Expand Down
2 changes: 1 addition & 1 deletion contrib/slim-shade/pom.xml
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.dremio.contrib</groupId>
<artifactId>dremio-contrib-parent</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<artifactId>dremio-slim-shade</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion contrib/tpch-sample-data/pom.xml
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>dremio-contrib-parent</artifactId>
<groupId>com.dremio.contrib</groupId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<artifactId>dremio-tpch-sample-data</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion dac/backend/pom.xml
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>com.dremio</groupId>
<artifactId>dremio-dac-parent</artifactId>
<version>1.0.8-201707190805180330-27f36e1</version>
<version>1.1.0-201708121825170680-436784e</version>
</parent>

<artifactId>dremio-dac-backend</artifactId>
Expand Down

This file was deleted.

14 changes: 13 additions & 1 deletion dac/backend/src/main/java/com/dremio/dac/daemon/DACDaemon.java
@@ -1,5 +1,17 @@
/*
* Copyright Dremio Corporation 2015
* Copyright (C) 2017 Dremio Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.dremio.dac.daemon;

Expand Down

0 comments on commit 57889fb

Please sign in to comment.